Adjust SAFE_URL_PATTERN regex for use with test method of regexes.
#33153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test` method on regexes does not behave like `match` on strings for checks if the regex matches when the global modifier (g) is present. Also adds a unit test on tooltips for sanitizing the same template twice.
|
@nikonthethird thank you for the backport! |
XhmikosR
approved these changes
Mar 2, 2021
This was referenced May 19, 2022
This was referenced Sep 23, 2024
This was referenced Sep 30, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR of #33136 for Bootstrap 4.
This also removes the global modifier from the
SAFE_URL_PATTERNregex, see the other PR for details why.Since Bootstrap V4 uses a different unit testing strategy than V5, based on the
distfiles, the sanitizer is not directly accessible since the file is inlined intotooltip.js. Therefore, the unit test for the sanitation has been added to the tooltip unit tests and simply adds two tooltips with the same HTML template to the test fixture. Then it checks that the tooltips contents are correct, using the same logic as the unit test in V5.I verified that the test works by first running it with the global modifier on the regex, where it fails, then removing the global modifier and it passes.